Skip to content

Conversation

@sebastienrousseau
Copy link
Owner

@sebastienrousseau sebastienrousseau commented May 12, 2024

Refactorings:

  • 🎨 Eliminated division operations to prevent timing variability.

Testing:

  • 🐛 Added a test case that triggers the KyberLibError::InvalidLength variant.

…ility

Replace division with multiply and shift to avoid DIV instruction and timing issues.
@sebastienrousseau sebastienrousseau changed the title Feat/kyberlib v0.0.6 May 12, 2024
@codecov
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.48%. Comparing base (a8d3285) to head (3987945).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   80.97%   81.48%   +0.51%     
==========================================
  Files          16       16              
  Lines        1151     1156       +5     
==========================================
+ Hits          932      942      +10     
+ Misses        219      214       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastienrousseau sebastienrousseau merged commit 9bbbade into main May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants