Non-latin characters in results

[mvarakin]

Windows 10 with Russian locale

Sometimes strings come in Russian (this is more less ok, we can deal with it)

But sometimes strings come in unreadable format

On the example above there is no way to find default iface among all the list as there is no ID but only description which is unreadable.

[mvarakin]

Hi! Any news here?

[sebhildebrandt]

@mvarakin ... i have refactored wmic that it should now support UTF8 characters. As I want to have confirmation that this works before publishing it to npm, can you test all functions on your side? Easiest way would be to close from GitHub and run tests like so:

git clone https://github.com/sebhildebrandt/systeminformation.git
cd systeminformation
npm run test

then go through all tests and see if results are fine on your side.

Thank you in advance!

[Phamier]

Nope
I think the issue goes even deeper. Windows doesn't use UTF-8 for displaying the info, but a localized encoding. For example, if you have a Russian localization turned on, Windows will display this info in Windows-1251 (old ass Russian encoding created before Unicode).
Microsoft will not change such a thing, because backwards compatibly is their first priority.
So... We are screwed... https://www.youtube.com/watch?v=0j74jcxSunY&ab_channel=Computerphile

[sebhildebrandt]

@Phamier @mvarakin thank you for testing ... I also got other feedback that this still is a problem. So I made more research and after hours I guess that at least for some (not all) of the commands I can solve the it ... let me work on it again a little bit and then we might see what I can come up with ... Hope that I have time to work on it the next weekend.

[sebhildebrandt]

@Phamier @mvarakin ,,, I made some more changes, not sure if I am able to really fix it ... can you test the latest code here from GitHub? Crossing fingers that this brought some improvements ... but maybe I have no chance here because netsh will create output backwards compatible (so no UTF8 ...)

[sebhildebrandt]

@mvarakin Can you test this one more time? I made a transition to powerShell also for networkInterfaces(). Hope that solves the problem now.

[sebhildebrandt]

@mvarakin, @Phamier ... as #610 addressed the same problem and is solved, I assume, that this is also fine. Can you confirm that?

[Phamier]

Yes! It's working properly now.

[Phamier]

It returns wrong iface, but It's a bug of Windows.

[sebhildebrandt]

@Phamier thank you for reporting!

[mvarakin]

Thanks a lot!