Skip to content

GLTF import texture upload#4033

Merged
Geenz merged 3 commits into
geenz/gltf-mesh-importfrom
marchcat/gltf-mesh-texture-import
May 18, 2025
Merged

GLTF import texture upload#4033
Geenz merged 3 commits into
geenz/gltf-mesh-importfrom
marchcat/gltf-mesh-texture-import

Conversation

@marchcat

@marchcat marchcat commented May 6, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@marchcat marchcat requested a review from Geenz May 6, 2025 13:45
@github-actions github-actions Bot added the c/cpp label May 6, 2025
@marchcat marchcat force-pushed the marchcat/gltf-mesh-texture-import branch from 2c012d4 to 5e8f871 Compare May 6, 2025 19:35
@Geenz

Geenz commented May 14, 2025

Copy link
Copy Markdown
Collaborator

@marchcat Looks good - I tried it locally as well. Looks like there's just a trailing white space that's getting flagged in the pre-commit. Fix that up, and I'll merge it in.

@marchcat

Copy link
Copy Markdown
Contributor Author

@Geenz, thank you!
Actually, scaling to 1/100th helps with some models, but it makes things worse for others (mostly the ones I downloaded from Sketchfab).
I'll add another commit for dynamic scaling once I resolve the conflicts with your branch — rigging seems to have affected it somehow.

@aiaustin

aiaustin commented May 14, 2025

Copy link
Copy Markdown

I mentioned this to Geenz already, but as this MAY (or may not) be related to the materials, I wonder if either of you are seeing GLTF mesh import messages that indicate "Error: Material of model is not a subset of reference model"?

Seen on all model uploads from Blender 4.4.3 GKTF/GLB built in exporter, even simple untextured cube using geenz/gltf-mesh-import as at approx. 6-May-2025. Maybe its fixed in recent work?

Cube-GLB.zip

Meant to be quick feedback. Sorry for cluttering up the PR.

@Geenz

Geenz commented May 14, 2025

Copy link
Copy Markdown
Collaborator

@aiaustin Please do not clutter up PRs with bug reports. File an issue instead.

@marchcat

marchcat commented May 14, 2025

Copy link
Copy Markdown
Contributor Author

"Error: Material of model is not a subset of reference model"

@aiaustin, you can click "Clear settings & reset form" to remove that error for now.

@marchcat marchcat force-pushed the marchcat/gltf-mesh-texture-import branch from fc6cd7f to 3569cc1 Compare May 14, 2025 20:43
@Geenz Geenz merged commit fdeef47 into geenz/gltf-mesh-import May 18, 2025
6 checks passed
@Geenz Geenz deleted the marchcat/gltf-mesh-texture-import branch May 18, 2025 18:51
@github-actions github-actions Bot locked and limited conversation to collaborators May 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants