#4128 Crash on mInvBindMatrix#4129
Merged
Merged
Conversation
marchcat
approved these changes
May 21, 2025
marchcat
approved these changes
May 21, 2025
maxim-productengine
approved these changes
May 21, 2025
Geenz
reviewed
May 22, 2025
|
|
||
| if (skin->mInvBindMatrix.size() < count ) | ||
| { | ||
| // faulty model? mInvBindMatrix.size() should have matched mJointNames.size() |
Collaborator
There was a problem hiding this comment.
invBindMatrix may not be present despite the model being rigged. Per the spec, the inverse bind matrices must be the same size as the joints array, but only when inverse bind matrices are present.
Contributor
Author
There was a problem hiding this comment.
Code below assumes that they match, crash happened on invBind. I know that it isn't nessesary, but I'm not certain if it should have been present in this particular case or if initSkinningMatrixPalette shoudn't have been called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.