Media changes including support for PRIM_MEDIA_FIRST_CLICK_INTERACT and HUD autoplay#4177
Merged
Merged
Conversation
marchcat
approved these changes
May 29, 2025
marchcat
left a comment
Contributor
There was a problem hiding this comment.
Thank you!
The test plan is 🔥
XML change looks cleaner now too.
Contributor
Author
|
I realized laying in bed last night (I know, sad) that I probably forgot to enable the all MOAP UI option, so I just pushed a commit just now that flips that on. The test plan already covers manually activating that with debugs (case 8) so it shouldn't be a blocker requiring a whole new build for testing since it's a tiny XUI change 🤞 |
Collaborator
|
@Dan-Linden @AtlasLinden As a heads up for test plans, a test plan is included at This generally looks good. Merging it into develop - should make it into the next release. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does three things which were relatively difficult for me to decouple:
Settings added are:
MediaAutoPlayHuds(bool) Allows web media on HUDs to autoplay even if the user disables autoplay for inworld mediaMediaFirstClickInteract(s32) Determines which (if any) objects are able to skip the focus click for their mediaWhile adding coverage for media first click interact I discussed the feature with a few people, and it was determined that also passing hover events to media contexts without explicitly granting focus was also expected, the biggest reason was support for things like hover tips and hover controls on webpages.
I admit that XUI is nowhere to be found on my list of strengths, so I apologize in advance for what I've done. If there is any input on how to improve anything about this PR I warmly welcome feedback. I wanted to make sure that everything fit, and it didn't look too terribly thrown together. It may be time to think about breaking this preferences category up, or moving into tabs. With WebRTC voice changes and additional settings from that likely, a section for voice alone would make a lot of sense and de-clutter this area a lot.
Lastly, a screenshot of the modified sound & media preferences panel for first impressions
This PR is a recreation of #3989 which was targeting the incorrect branch, and is unable to be reopened.