#4314 Fix model suffixes#4346
Merged
Merged
Conversation
marchcat
approved these changes
Jul 8, 2025
marchcat
reviewed
Jul 8, 2025
| // Set name and suffix. Suffix is nessesary for model matching logic | ||
| // because sometimes higher lod can be used as a lower one, so they | ||
| // need unique names not just in scope of one lod, but across lods. | ||
| pModel->mLabel = base_name + lod_suffix[mLod]; |
Contributor
There was a problem hiding this comment.
Thank you! I missed that before for some reason.
Contributor
Author
There was a problem hiding this comment.
Actually, this is still incomplete, need to add getLodlessLabel.
akleshchev
force-pushed
the
andreyk/viewer_4314
branch
from
87cc192 to
a424b6b
Compare
Usecase: Unable to use the same GLB model for physics
akleshchev
force-pushed
the
andreyk/viewer_4314
branch
from
a424b6b to
3623c71
Compare
Contributor
Author
|
Updated, added getLodlessLabel |
maxim-productengine
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usecase: Unable to use the same GLB model for physics