Add Yubikey example and link #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
reviewed
Oct 7, 2019
There was a problem hiding this comment.
Please consider removing the two commits that are already part of #1. Or, if we merge both here, please don't forget to address my review of #1.
The relevant commit that replaces minilock with yubikey looks good.
|
It looks like I messed up when making the new branch. I cleaned it up so that this only has the YubiKey commit. |
AA-Turner
added a commit
to mnm678/peps
that referenced
this pull request
Apr 26, 2022
See secure-systems-lab#2, python#1385 for context. Superseeds python#1565. This is the minimal core Sphinx support part, adding a bare minimum of useful things to get Sphinx to build and deploy, whilst not affecting the current build system. There is no theming or custom parsing needed to properly deal with PEPs. - `build.py` - build script - `conf.py` - Sphinx configuration - `Makefile` - new targets for Sphinx - `.gitignore` - add ignores for `venv` and `package` directories - `contents.rst` - Sphinx page to discover all PEPs - `deploy-gh-pages.yaml` - builds and deploys to github pages - `requirements.txt`
AA-Turner
added a commit
to mnm678/peps
that referenced
this pull request
Apr 26, 2022
See secure-systems-lab#2, python#1385 for context. Superseeds python#1566. This is the docutils parsing, transforms and writing part, building on PR python#1930. It contains a pseudo-package, `sphinx_pep_extensions`, which itself contains: ### Docutils parsing: - `PEPParser` - collates transforms and interfaces with Sphinx core - `PEPRole` - deals with :PEP:`blah` in RST source ### Docutils transforms: - `PEPContents` (Creates table of contents without page title) - `PEPFooter` (Dels with footnotes, link to source, last modified commit) - `PEPHeaders` (Parses RFC2822 headers) - `PEPTitle` - Creates document title from PEP headers - `PEPZero` - Masks email addresses and creates links to PEP numbers from tables in `pep-0000.rst` ### Docutils HTML output: - `PEPTranslator` - Overrides to the default HTML translator to enable better matching of the current PEP styles
AA-Turner
added a commit
to mnm678/peps
that referenced
this pull request
Apr 26, 2022
See secure-systems-lab#2, python#1385 for context. This is the RSS generation part, building on PR python#1930. It contains the logic for generating RSS This was originally in python#1385 and python#1565, split out for ease of review
AA-Turner
added a commit
to mnm678/peps
that referenced
this pull request
Apr 26, 2022
See secure-systems-lab#2, python#1385 for context. Superseeds python#1568. This is the Sphinx-theming part, building on PR python#1930. ### Stylesheets: - `style.css` - styles - `mq.css` - media queries ### Jinja2 Templates: - `page.html` - overarching template ### Javascript: - `doctools.js` - fixes footnote brackets ### Theme miscellany - `theme.conf` - sets pygments styles, theme internals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the minilock example to YubiKey