Tracking draft PR to remove deprecated functions #453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinKavik
reviewed
May 12, 2020
MartinKavik
reviewed
May 12, 2020
MartinKavik
reviewed
May 12, 2020
MartinKavik
reviewed
May 12, 2020
MartinKavik
reviewed
May 14, 2020
| since = "0.7.0", | ||
| note = "Use `LocalStorage::get` or `SessionStorage::get`." | ||
| )] | ||
| pub fn load_data<T>(storage: &Storage, name: &str) -> Option<T> |
There was a problem hiding this comment.
Probably we don't have to delete this function now. I think it's out of scope of this PR and in the future the whole service/storage will be deleted.
There was a problem hiding this comment.
I'll bring it back in in my next commit.
Closed
|
Closing in favor of #478 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added org file into this draft PR with notes, TODO's
Checklist
TODO: edit this top-level comment to include things that need to be removed
CRITICAL: restore clippys
builder.rsimplementations clearedbuildermodule taken out of public APIApp::new()in tests have init argument not Init code slated for deletion.internal code
builderdependencies removedinternal tests
builderdependencies removedbuilder/after_mount.rsimplementations clearedbuilder/before_mount.rsimplementations clearedbuilder/init.rsimplementations clearedtests pass running firefox. Chrome and safari unavailable.