Skip to content

Delete builder module #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
372 changes: 57 additions & 315 deletions src/app.rs

Large diffs are not rendered by default.

587 changes: 0 additions & 587 deletions src/app/builder.rs

This file was deleted.

86 changes: 0 additions & 86 deletions src/app/builder/after_mount.rs

This file was deleted.

118 changes: 0 additions & 118 deletions src/app/builder/before_mount.rs

This file was deleted.

110 changes: 0 additions & 110 deletions src/app/builder/init.rs

This file was deleted.

11 changes: 3 additions & 8 deletions src/app/cfg.rs
Original file line number Diff line number Diff line change
@@ -1,19 +1,16 @@
use super::types::{SinkFn, UpdateFn, ViewFn, WindowEventsFn};
use super::{builder::IntoAfterMount, MountType};
use super::types::{UpdateFn, ViewFn};
use crate::virtual_dom::IntoNodes;
use std::marker::PhantomData;
use std::rc::Rc;

#[allow(clippy::module_name_repetitions)]
pub struct AppInitCfg<Ms, Mdl, INodes, GMs, IAM: ?Sized>
pub struct AppInitCfg<Ms, Mdl, INodes, GMs>
where
Ms: 'static,
Mdl: 'static,
INodes: IntoNodes<Ms>,
IAM: IntoAfterMount<Ms, Mdl, INodes, GMs>,
{
pub mount_type: MountType,
pub into_after_mount: Box<IAM>,
pub takeover: bool,
pub phantom: PhantomData<(Ms, Mdl, INodes, GMs)>,
}

Expand All @@ -27,8 +24,6 @@ where
pub document: web_sys::Document,
pub mount_point: web_sys::Element,
pub update: UpdateFn<Ms, Mdl, INodes, GMs>,
pub sink: Option<SinkFn<Ms, Mdl, INodes, GMs>>,
pub view: ViewFn<Mdl, INodes>,
pub window_events: Option<WindowEventsFn<Ms, Mdl>>,
pub base_path: Rc<Vec<String>>,
}
3 changes: 1 addition & 2 deletions src/app/data.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use super::types::{MsgListeners, RoutesFn};
use super::types::MsgListeners;
use super::{RenderInfo, SubManager};
use crate::browser::util;
use crate::virtual_dom::{El, EventHandlerManager};
Expand All @@ -15,7 +15,6 @@ pub struct AppData<Ms: 'static, Mdl> {
pub main_el_vdom: RefCell<Option<El<Ms>>>,
pub popstate_closure: StoredPopstate,
pub hashchange_closure: StoredPopstate,
pub routes: RefCell<Option<RoutesFn<Ms>>>,
pub window_event_handler_manager: RefCell<EventHandlerManager<Ms>>,
pub sub_manager: RefCell<SubManager<Ms>>,
pub msg_listeners: RefCell<MsgListeners<Ms>>,
Expand Down
5 changes: 0 additions & 5 deletions src/app/orders/container.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ impl<Ms, Mdl, INodes: IntoNodes<Ms>, GMs> OrdersContainer<Ms, Mdl, INodes, GMs>
app,
}
}

pub(crate) fn merge(&mut self, mut other: Self) {
self.should_render = other.should_render;
self.effects.append(&mut other.effects);
}
}

impl<Ms: 'static, Mdl, INodes: IntoNodes<Ms> + 'static, GMs: 'static> Orders<Ms, GMs>
Expand Down
Loading