Skip to content

Conversation

@fallenbagel
Copy link
Collaborator

Description

Adds a configurable priority setting to the ntfy notification agent. Users can now select a priority level (Minimum, Low, Default, High, Urgent) from the ntfy settings page, instead of the previously hardcoded default value. This allows users to control how ntfy handles notification delivery and display.

How Has This Been Tested?

  • This has not been tested by me yet since this is not targeting Seerr 3.0.0 release

Screenshots / Logs (if applicable)

Checklist:

  • I have read and followed the contribution guidelines.
  • Disclosed any use of AI (see our policy)
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a configurable priority setting to the ntfy notification agent, allowing users to select from five priority levels (Minimum, Low, Default, High, Urgent) instead of the previously hardcoded default value of 3. This addresses issue #2060 which requested a priority picker similar to what exists for Gotify notifications.

Changes:

  • Added priority field to NotificationAgentNtfy interface with optional number type and default value of 3
  • Implemented priority dropdown selector in ntfy settings UI with validation
  • Updated ntfy agent to use configurable priority value with fallback to default
  • Added documentation for the new priority setting

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/i18n/locale/en.json Added translation keys for priority label and validation message
src/components/Settings/Notifications/NotificationsNtfy/index.tsx Added priority field with dropdown selector and Yup validation schema
server/lib/settings/index.ts Added priority field to NotificationAgentNtfy interface with default value
server/lib/notifications/agents/ntfy.ts Updated to use configurable priority from settings with fallback
docs/using-seerr/notifications/ntfy.md Added documentation section explaining the priority setting
Comments suppressed due to low confidence (1)

src/components/Settings/Notifications/NotificationsNtfy/index.tsx:72

  • The error message for topic validation is using the URL validation message key instead of the topic validation message key. Should use messages.validationNtfyTopic instead of messages.validationNtfyUrl.
          .required(intl.formatMessage(messages.validationNtfyUrl)),

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Priority picker for ntfy.sh

3 participants