Better handle errors where conversion occurs. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
May 18, 2021
bsneed
commented
- Adds exceptionFailure method.
- Better reports errors to developers where conversions or critical errors might occur.
migs647
reviewed
May 18, 2021
| internal func exceptionFailure(_ message: String) { | ||
| let args: [CVarArg] = [] | ||
| if isUnitTesting { | ||
| NSException.raise(NSExceptionName(_SegmentException), format: message, arguments: getVaList(args)) |
There was a problem hiding this comment.
Are we sure we want to use NSExceptions? They aren't friendly with recovery, and apple doesn't recommend usage unless you fail / exit
There was a problem hiding this comment.
Yeah, that's why I used them. I want a hard stop when unit testing or during development.
There was a problem hiding this comment.
Awesome, if that is the intention then we're good :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.