Skip to content

Add Adjust device mode integration sample & example app #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 1, 2021

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Jun 1, 2021

No description provided.

@bsneed bsneed changed the title Add adjust device mode integration & example app Add Adjust device mode integration sample & example app Jun 1, 2021
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

environment = ADJEnvironmentProduction
}

let adjustConfig = ADJConfig(appToken: settings.appToken, environment: environment)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to protect against an empty appToken? Can it be nil?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It potentially could be, but let adjust report that error.


Adjust.appDidLaunch(adjustConfig)

started = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to queue up any of these events if started hasn't happened yet?

.. If so, should we consider adding that feature to the core library?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly; working on that separately from this PR.

@bsneed bsneed merged commit ba409d3 into main Jun 1, 2021
@bsneed bsneed deleted the bsneed/destinations branch June 1, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants