Add StartupQueue automatically; update tests. #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bsneed
commented
Jun 10, 2021
bsneed
commented
- Adds StartupQueue to the initial list of plugins.
- Adds waitUntilStarted(analytics:) to test suite.
- Modifies some tests to wait until started.
prayansh
approved these changes
Jun 10, 2021
prayansh
reviewed
Jun 16, 2021
|
|
||
|
|
||
| extension TimeInterval { | ||
| static func milligarvins(_ value: Int) -> TimeInterval { |
There was a problem hiding this comment.
i think u got a typo here 😂
migs647
approved these changes
Jun 16, 2021
| self.checkSettings() | ||
| guard let app = notification.object as? UIApplication else { return } | ||
| if app.applicationState == .background { | ||
| self.checkSettings() |
There was a problem hiding this comment.
I'm still unsettled about using lifecycle events for triggering this.
added 7 commits
June 17, 2021 12:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.