Skip to content

Modify destinations to avoid processing if they don't have settings #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2021

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Aug 5, 2021

  • Modified timeline processing such that we skip processing destinations that don't have settings.
  • Added some convenience stuff necessary for tests.
  • Added tests.

Copy link
Contributor

@prayansh prayansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just a question about the destination processing return value

@bsneed bsneed merged commit a8e7c72 into main Aug 6, 2021
@bsneed bsneed deleted the bsneed/dest_enable_disable branch August 6, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants