Skip to content

Made working with and modifying payloads within plugins much simpler. #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 25, 2021
Merged

Made working with and modifying payloads within plugins much simpler. #83

merged 14 commits into from
Oct 25, 2021

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Oct 25, 2021

  • Logging is now available outside of an analytics instance.
  • Added convenience methods for modifying the integrations/context.
  • Added subscripts and methods for JSON value accessing/setting.
  • Optimized search order for keypath handlers.
  • Unit Tests

prayansh
prayansh reviewed Oct 25, 2021
View reviewed changes
migs647
migs647 reviewed Oct 25, 2021
View reviewed changes
migs647
migs647 reviewed Oct 25, 2021
View reviewed changes
Sources/Segment/Plugins/Logger/SegmentLog.swift
}
} else {
#if DEBUG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debating if we should change this from DEBUG to DEBUGLOG, that way our console doesn't get spammed and we can easily disable this and use Console as a backup. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really following what you mean here. Please hit me up on slack.

migs647
migs647 reviewed Oct 25, 2021
View reviewed changes
migs647
migs647 reviewed Oct 25, 2021
View reviewed changes
migs647
migs647 reviewed Oct 25, 2021
View reviewed changes
migs647
migs647 reviewed Oct 25, 2021
View reviewed changes
migs647
migs647 reviewed Oct 25, 2021
View reviewed changes
migs647
migs647 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@migs647 migs647 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just maybe some documentation and remove some commented tests.

@bsneed bsneed merged commit ff63cf6 into main Oct 25, 2021
@bsneed bsneed deleted the bsneed/dest_eaze branch October 25, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prayansh prayansh prayansh left review comments

@migs647 migs647 migs647 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsneed @migs647 @prayansh