The menu has no menu items

[mifi]

I get this error if I use the disabled prop for Menu.Item and if all menu items in a Menu.Group are disabled. Can we remove this line of code?

evergreen/src/menu/src/Menu.js

Line 29 in 29f9c41

throw new Error('The menu has no menu items')

Maybe instead return?
I can submit a pr if this is the correct solution

[akleiner2]

I'd be fine either removing that line, or just throwing that error in dev -- happy to accept a PR either way.

[dudhatdhavalm]

Is this issue still open or not?
if it is still open then I would like to do my first contribution.

[mifi]

Still an issue. Feel free to contribute :)
IMO the line should be removed, or the code that counts menu items should include disabled menu items in the count. This bug is a very sneaky one because it seems to work fine, until you happen to end up in a state where all menu items are disabled (or the single item, if just one), then it will crash!

[brandongregoryscott]

Published with v6.7.1