-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
several fix and enhancements #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a5307a1
fix: style dropdown bootstrap4/5
fabienwnklr e89dfb9
fix: appareance with input-group class
fabienwnklr 6fa9c85
feat: add ignoreOnDropdownHeight property
fabienwnklr f27a842
fix: calcul dropdownheight with optgroup
fabienwnklr 2a4d1c5
fix: style for input-group class
fabienwnklr 86226c8
fix: add separator height to dropdown height calcul
fabienwnklr 00615d6
Merge branch 'selectize:master' into master
fabienwnklr 5eae8b0
Merge branch 'selectize:master' into master
fabienwnklr f95e0f5
Merge branch 'selectize:master' into master
fabienwnklr 8ded584
Merge branch 'selectize:master' into master
fabienwnklr 5938d28
feat: add option 'search'
fabienwnklr ddd62bd
test: add test for normalize/search options
fabienwnklr 40e0b2c
fix: different style for select/active option
fabienwnklr 13526f3
fix: persitant state style for selected item
fabienwnklr 6517863
Merge branch 'master' of github.com:fabienwnklr/selectize.js
fabienwnklr 3888f15
fix: peristant style for selected option
fabienwnklr 167101b
Merge branch 'selectize:master' into master
fabienwnklr 5e23c42
fix: prevent the keyboard on mobile devices
fabienwnklr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a problem with ReadOnly.
If the person clicks on the input and types something on the physical keyboard the input will remain empty, but selectize will filter the items and will work anyway.
To fix this just listen to the focus event and when the input receives focus you apply a blur. That way the input will never be focused and the person will never be able to type anything and we won't have any problems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A suggestion also to prevent the keyboard on mobile devices is to use $control_input.attr("inputmode", "none");
Some mobile browsers ignore the read_only property and show the keyboard anyway. But they respect input_mode.
The ideal is to have the 2 codes, read_only and input_mode none.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much for your feedback, I fixed that !