Skip to content

Support composer/ca-bundle fallback #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

colinodell
Copy link
Contributor

Fixes #90

This is one of three possible solutions to #90 (see #103 and #104). This one can be included with either #103 or #104 if you'd like.

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • If composer/ca-bundle is installed, it'll use that to locate a CA bundle and configure curl to use that. This will be either the system's default, or Mozilla's if none is found

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2018
@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #105 into master will decrease coverage by 2.31%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
- Coverage    84.7%   82.38%   -2.32%     
==========================================
  Files           3        3              
  Lines         170      176       +6     
==========================================
+ Hits          144      145       +1     
- Misses         26       31       +5
Impacted Files Coverage Δ
lib/Client.php 78.91% <16.66%> (-2.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9a04d9...a39209d. Read the comment docs.

@thinkingserious thinkingserious added status: waiting for feedback waiting for feedback from the submitter and removed status: code review request requesting a community code review or review from Twilio labels Oct 3, 2018
@colinodell
Copy link
Contributor Author

This change has been merged (via cherry-pick) into #103

@colinodell colinodell closed this Oct 4, 2018
@colinodell colinodell deleted the support-composer-ca-bundle-fallback branch October 4, 2018 01:32
@devchas devchas added difficulty: medium fix is medium in difficulty hacktoberfest status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap labels Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: waiting for feedback waiting for feedback from the submitter status: work in progress Twilio or the community is in the process of implementing type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document and throw an error to help people with CURLOPT_SSL_VERIFYPEER issues
3 participants