Skip to content

feat: automatic code style checking #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 10, 2020

Conversation

misantron
Copy link
Contributor

@misantron misantron commented Oct 4, 2018

Fixes

Closes #108

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Run code style authomatic checking (PSR-1, PSR-2) on TravisCI build
  • Make it possible to run unit tests and CS check with Composer commands
  • Some fixes in TravisCI project configuration

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 4, 2018
@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #109 into master will decrease coverage by 3.75%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
- Coverage   88.00%   84.24%   -3.76%     
==========================================
  Files           4        2       -2     
  Lines         175      165      -10     
==========================================
- Hits          154      139      -15     
- Misses         21       26       +5     
Impacted Files Coverage Δ
lib/Client.php 81.56% <100.00%> (-3.76%) ⬇️
lib/Response.php 100.00% <100.00%> (ø)
lib/Exception/InvalidRequest.php
test/unit/MockClient.php

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51e69a9...96859ef. Read the comment docs.

@thinkingserious thinkingserious added hacktoberfest difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 9, 2018
@thinkingserious
Copy link
Contributor

Hello @misantron,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Copy link
Contributor

@peter279k peter279k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me.
Some request chnages need to be cncerned.

@misantron
Copy link
Contributor Author

@peter279k made fixes for ext-mbstring dependency and EOF in gitignore and phpunit.xml.dist

@thinkingserious
Copy link
Contributor

Hello @misantron,

Thanks again for the PR!

We noticed that you have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold.

Also, please be sure that you have officially registered here.

Thank you and Happy Hacktobering!

Team SendGrid DX

@misantron
Copy link
Contributor Author

@thinkingserious
Copy link
Contributor

Hello @misantron,

Thanks again for the PR!

You have earned 3 out of the 5 points needed to receive glorious SendGrid Hacktoberfest swag.

Please take a moment to checkout this link to find more issues to get you past the required threshold or to simply continue the celebration.

Also, please be sure you have officially registered with us here by November 1, 2018 to qualify.

If you have any questions you can email us at [email protected].

Thank you and Happy Hacktobering!

Team SendGrid

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice work!

@childish-sambino childish-sambino changed the title Issue 108 - code style authomatic checking feat: automatic code style checking Jul 10, 2020
@childish-sambino childish-sambino merged commit cd727b9 into sendgrid:master Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require conformance to style standards
4 participants