-
Notifications
You must be signed in to change notification settings - Fork 68
feat: automatic code style checking #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 88.00% 84.24% -3.76%
==========================================
Files 4 2 -2
Lines 175 165 -10
==========================================
- Hits 154 139 -15
- Misses 21 26 +5
Continue to review full report at Codecov.
|
Hello @misantron, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me.
Some request chnages need to be cncerned.
@peter279k made fixes for ext-mbstring dependency and EOF in gitignore and phpunit.xml.dist |
Hello @misantron, |
Hello @misantron, |
# Conflicts: # .travis.yml # composer.json # lib/Client.php # lib/Response.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice work!
Fixes
Closes #108
Checklist
Short description of what this PR does: