Skip to content

Added more documentation #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Added more documentation #98

merged 2 commits into from
Apr 10, 2018

Conversation

martijnmelchers
Copy link
Contributor

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Added methods to the Client.php I don't know if I got them all or if this is the right way. Open for suggestions!

MartijnMelchers added 2 commits April 9, 2018 23:35
…o do this but I couldn't find it. Missed any? Please let me know!
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Apr 9, 2018
@SendGridDX
Copy link

SendGridDX commented Apr 9, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 9, 2018

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #98   +/-   ##
======================================
  Coverage    84.7%   84.7%           
======================================
  Files           3       3           
  Lines         170     170           
======================================
  Hits          144     144           
  Misses         26      26
Impacted Files Coverage Δ
lib/Client.php 81.56% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc5cc8d...5de4cad. Read the comment docs.

@thinkingserious
Copy link
Contributor

Hello @martijnmelchers,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Falseclock pushed a commit to Falseclock/php-http-client that referenced this pull request Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants