Skip to content

fix: Use the private body and header datamembers for DeserializeResponseBodyAsync and DeserializeResponseHeaders #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Wind010
Copy link
Contributor

@Wind010 Wind010 commented Dec 18, 2021

…dyAsync and DeserializeResponseHeaders. Add unit tests.

Fixes

Fixes #1081

A short description of what this PR does.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

…dyAsync and DeserializeResponseHeaders. Add unit tests.
@shwetha-manvinkurke shwetha-manvinkurke changed the title Use the private body and header datamembers for DeserializeResponseBo… fix: Use the private body and header datamembers for DeserializeResponseBo… Feb 8, 2022
@childish-sambino childish-sambino changed the title fix: Use the private body and header datamembers for DeserializeResponseBo… fix: Use the private body and header datamembers for DeserializeResponseBodyAsync and DeserializeResponseHeaders Feb 24, 2022
@childish-sambino childish-sambino merged commit 61d84f2 into sendgrid:main Feb 24, 2022
@jamesfernandes
Copy link

@childish-sambino How is this not marked as a breaking change?? ref. FluentEmail.SendGrid

@childish-sambino
Copy link
Contributor

@jamesfernandes Eep, this was a miss. Will work on a fix/revert.

@jamesfernandes
Copy link

Phew thanks @childish-sambino.
@thinkingserious suggested creating an issue; would that be helpful?

@childish-sambino
Copy link
Contributor

@jamesfernandes Meh, issue not needed. Went ahead and published a fix: #1168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeserializeResponseBodyAsync takes parameter?
4 participants