Skip to content

feat: make RetriableServerErrorStatusCodes public #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 8, 2022

Conversation

maxkoshevoi
Copy link
Contributor

Fixes

Made RetriableServerErrorStatusCodes public. This is useful if user wants to implement custom retry logic (in my case it's rescheduling bus message), or amend existing list (don't have an example for this one, but it also might be useful)

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@eshanholtz
Copy link
Contributor

eshanholtz commented Jan 26, 2022

Hi @maxkoshevoi thanks for the PR! Can you please address the test failure and add some additional testing around the new public capabilities here?

@eshanholtz eshanholtz added the status: waiting for feedback waiting for feedback from the submitter label Jan 26, 2022
@maxkoshevoi
Copy link
Contributor Author

maxkoshevoi commented Jan 26, 2022

Turns out .Net Framework 4.0 doesn't have IReadOnlyList. Replaced it with regular List

Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@childish-sambino childish-sambino changed the title Make RetriableServerErrorStatusCodes public feat: make RetriableServerErrorStatusCodes public Mar 8, 2022
@childish-sambino childish-sambino merged commit 9088127 into sendgrid:main Mar 8, 2022
@maxkoshevoi maxkoshevoi deleted the mk/public-retry-codes branch March 9, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for feedback waiting for feedback from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants