Skip to content

fix: update setup to allow strong naming on Travis #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkingserious merged 1 commit into from
Jan 26, 2020
Merged

fix: update setup to allow strong naming on Travis #975

thinkingserious merged 1 commit into from
Jan 26, 2020

Conversation

@jnyrup
Copy link
Contributor

@jnyrup jnyrup commented Jan 25, 2020

Fixes

Fixes #972

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Updates the Travis setup to hopefully unlock assembly signing capabilities

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 25, 2020
@jnyrup jnyrup marked this pull request as ready for review January 25, 2020 23:51
@thinkingserious
Copy link
Contributor

thinkingserious commented Jan 26, 2020

Nicely done, thank you!

@thinkingserious thinkingserious changed the title [WIP] Update setup to allow strong naming on Travis fix: update setup to allow strong naming on Travis Jan 26, 2020
@thinkingserious thinkingserious merged commit b5a0cba into sendgrid:master Jan 26, 2020
@thinkingserious
Copy link
Contributor

thinkingserious commented Jan 26, 2020

Hello @jnyrup,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@jnyrup jnyrup deleted the strongnaming branch January 26, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thinkingserious thinkingserious thinkingserious approved these changes

Assignees

No one assigned

Labels

status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Strong name signature could not be verified

2 participants

@jnyrup @thinkingserious