PHP API - empty response body

[CodeMiner84]

Hello,

about 2-3 weeks ago I was implementing SendGrid php api to my client. Back then when I was using:

$response = $client->client->contactdb()->recipients()->post([$request_body]);

I've received:

object(SendGrid\Response)[5] public '_status_code' => int 201 public '_body' => string '{"error_count":0,"error_indices":[],"new_count":0,"persisted_recipients":["bS5waWV0cmFzekBuZXVyb3N5cy5wbA=="],"unmodified_indices":[0],"updated_count":0}' (length=153) public '_headers' => string 'HTTP/1.1 201 CREATED Server: nginx ... ...
this was on version 5.0.9.

Right now in 5.1.1 I receive this:

/home/michal/sendgrid/lib/SendGridHelper.php:76: object(SendGrid\Response)[5] protected 'statusCode' => int 201 protected 'body' => boolean false protected 'headers' => array (size=1) 0 => string '1' (length=1)

as you can see the response body is empty. But weird is that I can catch proper body with this code:
ob_start(); $response = $client->client->contactdb()->recipients()->post([$request_body]); $curl_response = ob_get_contents();
so in my $curl_response variable I would have this:
{"error_count":0,"error_indices":[],"new_count":0,"persisted_recipients":["bS5waWV0cmFzekBuZXVyb3N5cy5wbA=="],"unmodified_indices":[0],"updated_count":0}

Please fix this bug because right now I need to use old version :)

[thinkingserious]

Hi @Madara84,

Thanks for letting us know and for providing a detailed issue!

I've added this to our backlog for a fix.

[mpietraszneurosys]

could you give me an estimation time when it will be fixed on master branch ?

[thinkingserious]

Hi @mpietraszneurosys,

It does not look like this would get fixed this quarter unless we get more people voting on this issue or if someone submits a pull request.

[vsmori]

@mpietraszneurosys
@mpietraszneurosys

Quick Fix:

Edit sendgrid's Client.php and add the following lines :

    curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
    curl_setopt($curl, CURLOPT_HEADER, true);
    curl_setopt($curl, CURLOPT_CUSTOMREQUEST, strtoupper($method));
    curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, false);

After the following line:

    curl_setopt($curl, CURLOPT_HTTPHEADER, $this->headers);

in makeRequest function.

[harryhaibojiang]

I encountered the same problem. @vsmori 's solution works.

[cballenar]

Same issue here, @vsmori 's solution worked as well. Please address.

[thinkingserious]

Thanks for sharing your solution @vsmori. Please fill out this form so we can send you some swag :)

@haibo3318, @cballenar,

Thanks for your votes, I've added them to our backlog.

[vsmori]

@thinkingserious , please send again the form.

[thinkingserious]

@vsmori, sorry about that, here it is.

[birdy247]

I am also seeing this issue. The above worked for me.

[ylupien]

Stop turning off CURLOPT_SSL_VERIFYPEER and fix your PHP config

Disabling verification of the certificate allows bad guys to man-in-the-middle the communication without you knowing it. Disabling verification makes the communication insecure. Just having encryption on a transfer is not enough as you cannot be sure that you are communicating with the correct end-point.

References :
https://snippets.webaware.com.au/howto/stop-turning-off-curlopt_ssl_verifypeer-and-fix-your-php-config/
https://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html

Remove this setting by default and let unsecure users to turn it off with a configuration.

if ($this->disableSSLVerifyPeer) {
  curl_setopt($curl, CURLOPT_SSL_VERIFYPEER, false);
}

[thinkingserious]

Thanks for the feedback @ylupien,

I have added your vote.