Allow sharing playlists across multiple users #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, abuild refuses to run correctly.
nadiamoe
commented
Jul 4, 2024
| @@ -122,6 +140,21 @@ func (s *Store) Read(relPath string) (*Playlist, error) { | |||
| playlist.Comment = value | |||
| case attrIsPublic: | |||
| playlist.IsPublic, _ = strconv.ParseBool(value) | |||
| case attrSharedWith: | |||
| sharedWith := strings.Split(value, ",") | |||
There was a problem hiding this comment.
Currently thinking whether it would be better for this to be a comma-separated list (as it is now), or if we should use the comment multiple times 🤔
#GONIC-NAME:"Roobre"
#GONIC-COMMENT:""
#GONIC-IS-PUBLIC:"false"
#GONIC-SHARED-WITH:"2"
#GONIC-SHARED-WITH:"3"
The latter sounds easier to parse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take at #522, implementing the easiest functional approach to sharing playlists by specifying a list of users that can edit another user's playlist.
For now, there is no UI for "inviting" users, the m3u file needs to be edited by hand. Users with whom a playlist has been shared can add/remove items from it, but not delete the playlist itself.
Includes commits from #524