Skip bookmarks for missing items instead of failing #580
Conversation
|
I can also see cleaning the bookmarks for missing items at this point as well, happy to add that if it is the preferred solution. Not returning them and not cleaning them means that this table can grow indefinitely. |
khers
force-pushed
the
bookmark-missing-items
branch
from
7234203 to
2aa8e76
Compare
Currently if a bookmark exists for an item that does not exist in the db, either because it has been removed or it never did, the user is prevented from retrieving any bookmarks. We can be in this state if media has moved or been deleted, but also because the createBookmark endpoint does not verify the item id provided. This patch makes the getBookmarks endpoint ignore bookmarks for missing items. Fixes: sentriz#578 Signed-off-by: Eric B Munson <[email protected]>
khers
force-pushed
the
bookmark-missing-items
branch
from
2aa8e76 to
7bb04eb
Compare
@khers makes sense, we could probably have some cleanBookmarks in the scanner |
) Currently if a bookmark exists for an item that does not exist in the db, either because it has been removed or it never did, the user is prevented from retrieving any bookmarks. We can be in this state if media has moved or been deleted, but also because the createBookmark endpoint does not verify the item id provided. This patch makes the getBookmarks endpoint ignore bookmarks for missing items. Fixes: #578 Signed-off-by: Eric B Munson <[email protected]>
|
thanks! |
I will look into this but it might take me a minute, totally new to go. |
Currently if a bookmark exists for an item that does not exist in the db, either because it has been removed or it never did, the user is prevented from retrieving any bookmarks. We can be in this state if media has moved or been deleted, but also because the createBookmark endpoint does not verify the item id provided.
This patch makes the getBookmarks endpoint ignore bookmarks for missingitems.
Fixes: #578