Support for time INTERVAL data type in postgres

[mark-lester]

I have times > 24 hours, which just broke upon moving to postrgres, so I think I need to implement an INTERVAL data type in data-types.js.

[mark-lester]

I added the obvious

/**
 * A time interval column
 * @property INTERVAL
 */

var INTERVAL = function() {
  if (!(this instanceof INTERVAL)) return new INTERVAL();
  ABSTRACT.apply(this, arguments);
};
util.inherits(INTERVAL, ABSTRACT);

INTERVAL.prototype.key = INTERVAL.key = 'INTERVAL';
INTERVAL.prototype.toSql = function() {
  return 'INTERVAL';
};

and the entry in module.exports.
Unless I get told otherwise I'll submit that shortly. I cant fully test yet as I have a weird bug on constraints and block inserts (it goes away when I bring the block size down so I need to have a proper look at what is being said to postrgres)

[mickhansen]

The newer version uses ABSTRACT.inherts(cb) afaik, but @janmeier is more knowledgeable here.

[janmeier]

Have a look at https://github.com/sequelize/sequelize/blob/master/lib/dialects/postgres/data-types.js for an example of how to extend the abstract datatype.

You'll need to add an entry in https://github.com/sequelize/sequelize/blob/master/lib/data-types.js as well, like with hstore and json, otherwise the type won't be accessible

[janmeier]

ping @mark-lester :)

[mark-lester]

Hey. where did I get to ?, I think I gave up, yes, I aborted and went for strings, because ...,
https://groups.google.com/forum/#!topic/sequelize/IBoT8wf72tg
I am just in the middle of critical phase in today's cooking, let me remember why I bottled out, ..., brb

[janmeier]

While other dialects use strings to identify their types (e.g. INTEGER, GEOMETRY etc), postgres uses oids, which are numbers. The oid for interval is 1186, and interval[] is 1187. Most oids are static, but those for user created types / types you have to manually enable, fx geometry and hstore are dynamic.

(You can check for an oid using `select typname, oid, typarray from pg_type where typtype = 'b')

[mark-lester]

ok, thanks,
I am about to return to the server and so will have another punt, I need to to implement a sequence manager, something that does this kind of thing (all totally untested).

sequenceManage:function(offset){
    var self=this;
    var query = "UPDATE "+this.tableName+
        " SET "+this.sequenceName+" = "+this.sequenceName+"+"+offset+
        " WHERE "+this.sequenceName +" >= "+this.get(this.sequenceName);
    _.each(this.seqIndexes,function(seqIndex){
        query+=" AND "+seqIndex+"="+self.get(seqIndex);
    });
    return this.sequelize.query(query);
},

and this

            modelDef.hooks={
                beforeInsert: function(record, options) {
                    this.sequenceManage(1);
                },
                    afterDelete: function(record, options) {
                    this.sequenceManage(-1);
                }
            },

and obviously give your def a sequenceName (name of field that holds the sequence) and sequencIndex[], list of fields to sequence across.
If there's a thing to do that pray tell, but I will go back now and attempt to return to using INTERVAL

[mark-lester]

I need guidance.
I am trying to bend an INTERVAL into a timey thing that returns a string of the form H:m:s
I made this parse method, but to no avail, interval is a "H:m:s" string already, but I am getting an object from my query .

 INTERVAL.parse  = INTERVAL.prototype.parse=function(interval) {
    _.each( ['hours','minutes','seconds'],function(arg){
       if (interval[arg].length === 1)
          interval[arg]="0"+interval[arg];
    });

    return interval.hours+":"+interval.minutes+":"+interval.seconds;
  };

any clues on where I am supposed to stop an INTERVAL field from returning an object consisting of hours,minutes and seconds.,
and is this what we really want anyway ?. The object form might be what we should have. What I myself want is just an H:m:s string where H can be > 24. is that fair ?.

[janmeier]

I don't have any strong feelings about the returned type for interval, since you are the one implementing it, feel free to write it to suit your needs.

Adding a .parse method should be all that's required - Is that method being called at all? Perhaps you can create a pull request with what you have so far, that would make it easier for me to offer some guidance

[mark-lester]

OK, I let this slip as I went off back into the client. I have some other stuff now, namely I want to do things like select "name",earth_distance (ll_to_earth(88.9761,24.621281) , ll_to_earth("lon","lat")) from "Stops"; so that would be a cool thing to have.
I did some work previously on epilogue so it could do aggregates like max and min, and you can append $lt etc so you can do afield$lt=, so I got near to this stuff, at least using the interface.
I'll have another look first and then post an issue. If someone has done any gis stuff and I just cant see it please say.