Skip to content

TelemetryConfiguration.Active#206

Open
idrivediesel2006 wants to merge 1 commit into
serilog-contrib:devfrom
idrivediesel2006:patch-1
Open

TelemetryConfiguration.Active#206
idrivediesel2006 wants to merge 1 commit into
serilog-contrib:devfrom
idrivediesel2006:patch-1

Conversation

@idrivediesel2006

Copy link
Copy Markdown

According to Microsoft in this PR (microsoft/ApplicationInsights-dotnet#1148) they recommend using Telemetry.CreateDefault().

According to Microsoft in this PR (microsoft/ApplicationInsights-dotnet#1148) they recommend using Telemetry.CreateDefault().
@nblumhardt

Copy link
Copy Markdown
Contributor

Thanks for the heads-up. I think we should probably remove this example entirely - the only really useful way to configure this sink currently is with a connection string or via injection of the telemetry client through DI, IIRC 🤔

@Saibamen Saibamen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread README.md
Comment on lines +13 to +14
// TelemetryConfiguration.Active is obsolete
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TelemetryConfiguration.Active is obsolete
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148

No need to add this for readme

Comment thread README.md
Comment on lines +23 to +24
// TelemetryConfiguration.Active is obsolete
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TelemetryConfiguration.Active is obsolete
// https://github.com/microsoft/ApplicationInsights-dotnet/pull/1148

No need to add this for readme

@Saibamen

Copy link
Copy Markdown

I think we should probably remove this example entirely

@nblumhardt: I'm still using this style of configuring logger and output template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants