Allow to extend or remove predefined column #124
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quinvit Could you please take a look at the conflicts? |
|
I am closing this PR since @quinvit hasn't followed up. I was going to open my own PR to reproduce these changes, but I am unclear about the intended usage of the new Qui, if you return to implement these changes in the current codebase, or if someone else understands that override setting and wants to implement this, in keeping with the sink's terminology please use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some predefined columns should be customized to support database index (nvarchar(max) doesn't support index) or able to removed when client doesn't need it.