Allow choice of config method for newer framework clients #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
Because of NuGet assumptions about which package framework variant applies to a given package consumer's target framework, it wasn't possible for
net461or newer apps to use M.E.C configuration (despite beingnetstandard2.0-compatible), and it wasn't possible fornetcoreapp2.0or newer apps to use System.Configuration config (despite MS having added it to .NET Core 2.0).The issue explains how this is addressed (additional TFMs and some shared code between them). Also added some System.Configuration unit tests since that is a lot more complex after #167 and fixed a couple of edge-case bugs those tests uncovered (three cheers for unit tests).
As usual I will leave this PR open for a couple days in case anyone wants to offer feedback.
Hopefully after this we can do a master-branch release!