[LTB-65] Add Buildable for ConfigRec #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasqu4le
reviewed
Sep 6, 2021
|
Ah one more thing, I think that the commit message for b4e16fe has a typo: Also, there's no written rule AFAIK, but in several projects for these commits that are not directly related to an issue we use the "tag" |
https://www.merriam-webster.com/dictionary/indention
|
Problem: 1. Our style guide requires two spaces indentation, but in some places we have four or even more spaces. 2. Someone may have different formatter settings but we do not want someone reformat our code just saving file. Solution: 1. Delete spaces where it contradicts our style guide. 2. Add stylish-haskell config.
worm2fed
force-pushed
the
worm2fed/ltb-65-buildable-for-configrec
branch
from
e60e28b to
b8b0064
Compare
|
@pasqu4le if you want, you can take a look at requested changes |
oh I didn't know that, I assumed it was a typo. No problem then 👌 |
Problem: This was made here #53. But this PR became still. It'll be good to proceed this PR and add Buildable instances, cause it's quite useful. We not going to merge #53, because Json instances was added recently independent from this PR (we didn't know about it). Solution: Move Buildable instances (along with tests) form #53.
worm2fed
force-pushed
the
worm2fed/ltb-65-buildable-for-configrec
branch
from
b8b0064 to
b516300
Compare
delete-merged-branch
bot
deleted the
worm2fed/ltb-65-buildable-for-configrec
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
This was made here #53. But this PR became still.
It'll be good to proceed this PR and add Buildable instances, cause it's quite useful.
We're not going to merge #53, because Json instances was added recently independent from this PR (we didn't know about it).
Solution:
Move Buildable instances (along with tests) form #53.
Also in thins PR presented one stylistic commit with formatter config.