Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

getter function for http base class in api handler #2344

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/libs/core/src/handle/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ export const handleApi = async (
if (route.isApi) {
const { page } = route as ApiRoute;
setCustomHeaders(event, routesManifest);
if (!event.req.hasOwnProperty("originalRequest")) {
Object.defineProperty(event.req, "originalRequest", {
get: () => event.req
});
}
if (!event.res.hasOwnProperty("originalResponse")) {
Object.defineProperty(event.res, "originalResponse", {
get: () => event.res
});
}
getPage(page).default(event.req, event.res);
return;
}
Expand Down
37 changes: 31 additions & 6 deletions packages/libs/core/tests/handle/api.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,42 @@ describe("Api handler", () => {
${"/rewrite/2"} | ${"pages/api/dynamic/[id].js"}
${"/rewrite-query/3"} | ${"pages/api/static.js"}
`("Routes api request $uri to page $page", async ({ uri, page }) => {
const route = await handleApi(
mockEvent(uri),
manifest,
routesManifest,
getPage
);
const event = mockEvent(uri);
const route = await handleApi(event, manifest, routesManifest, getPage);

expect(route).toBeFalsy();
expect(getPage).toHaveBeenCalledWith(page);
expect((event.req as any).originalRequest).toBe(event.req);
expect((event.res as any).originalResponse).toBe(event.res);
});

it.each`
uri | page
${"/api"} | ${"pages/api/index.js"}
${"/api/static"} | ${"pages/api/static.js"}
${"/api/dynamic/1"} | ${"pages/api/dynamic/[id].js"}
${"/rewrite"} | ${"pages/api/static.js"}
${"/rewrite/2"} | ${"pages/api/dynamic/[id].js"}
${"/rewrite-query/3"} | ${"pages/api/static.js"}
`(
"Routes api request $uri to page $page with NodeNextRequest & NodeNextResponse",
async ({ uri, page }) => {
const event: any = mockEvent(uri);
event.req.originalRequest = {};
event.res.originalResponse = {};
const route = await handleApi(event, manifest, routesManifest, getPage);

expect(route).toBeFalsy();
expect(getPage).toHaveBeenCalledWith(page);
expect((event.req as any).originalRequest).toBe(
(event.req as any).originalRequest
);
expect((event.res as any).originalResponse).toBe(
(event.res as any).originalResponse
);
}
);

it.each`
uri
${"/api/notfound"}
Expand Down