This repository was archived by the owner on Dec 9, 2024. It is now read-only.
Make queueName and topicName as not required in ServiceBus outbinding… #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Otherwise generated functions.json will include topicName and queueName with default value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…. Otherwise generated functions.json will include topicName and queueName with default value.
What did you implement:
Closes #352
How did you implement it:
The service bus binding need either queueName or topicName
How can we verify it:
I link it to my project which use service bus out binding with topic and did a sls deploy. Verify the function.json only contain topicName instead of both topicName and queueName attribute.
Todos:
Need the ability to require either attribute. Basically we need the ability to specify topicName or queueName is required.
Is this ready for review?: YES
Is it a breaking change?: NO