Skip to content

Update index.js to fix package individually. #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

slslazy
Copy link

@slslazy slslazy commented Nov 30, 2021

The change allows the use of the package individually true combined with sls deploy function -f func_name.

The change allows the use of the package individually true combined with sls deploy function -f func_name.
@pgrzesik
Copy link
Contributor

Hello, could you explain that solution a little bit? Would you be able to cover it with unit test? I'm not sure why/how that solves the problem and would really appreciate a walkthrough 🙇

@rileypriddle
Copy link
Contributor

rileypriddle commented Dec 2, 2021

@pgrzesik looks like it's for this issue #605

@pgrzesik
Copy link
Contributor

pgrzesik commented Dec 2, 2021

Thanks a lot for linking that @rileypriddle, it indeed seems like the solution to that issue. It would be good to confirm with test case that it solves the issue and we should be good to go with this one @slslazy 🚀

@rileypriddle
Copy link
Contributor

Duplicate of #613

@pgrzesik
Copy link
Contributor

pgrzesik commented Jan 9, 2022

Hello @slslazy 👋 Are you interested in getting this PR through the finish line? It would be good to confirm that it works as intended with a test case

martinpfannemueller-syntax added a commit to martinpfannemueller-syntax/serverless-python-requirements that referenced this pull request Feb 17, 2022
daxiang28 added a commit to scribble-art/serverless-python-requirements that referenced this pull request Apr 27, 2022
@keyto123
Copy link

While you wait for this to merge.
sed -i 's/inputOpt\.functionObj/this\.serverless\.service\.functions\[inputOpt\.function\]/' node_modules/serverless-python-requirements/index.js

make this a bash function or set as a postinstall step in package.json to replace broken code with working one

@pgrzesik
Copy link
Contributor

Thanks @slslazy 🙇 I will finalize it as a part of: #725 after stabilizing tests. I will close this PR.

@pgrzesik pgrzesik closed this Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants