Merged
Conversation
don't initialize window.Audio as part of an automatic setup, it will Barf in packager such as webpack, rollbar etc.
instead make it part of the init call - like so:
```
Amplitude.init({
audio: new Audio(),
bindings: {
37: 'prev',
39: 'next',
32: 'play_pause',
})
```
or alternatively wrap it in a conditional ```if(window && window.Audio)```
Contributor
|
Thank you for submitting your PR! I'll make the change to initialize the audio on init. |
Contributor
|
With the last PR of #420 , we can set this to null and the audio will get initialized through the changeSong method. This is convenient since we change the song to be the initialized song. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
don't initialize window.Audio as part of an automatic setup, it will Barf in packagers such as webpack et.all.
instead make it part of the init call - like so:
or alternatively wrap it in a conditional
if(window && window.Audio)