This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Allow core-graphics 0.8 and bump version #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may break things downstream for people using core-graphics 0.7. Ranges caused issues in the past already. |
|
Ok, then let's not do ranges :p |
|
@Eijebong asked me to test this, and it compiles fine on macOS 10.12.5 with rustc 1.18 (stable). |
|
This still needs an update @Eijebong. |
|
Woups, pushed on the wrong branch ^^ |
|
@bors-servo r+ |
|
📌 Commit 9e3557f has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 15, 2017
Allow core-graphics 0.8 and bump version <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/cocoa-rs/162) <!-- Reviewable:end -->
|
Thanks @killercup for testing again! |
|
💔 Test failed - status-travis |
|
@bors-servo retry
|
bors-servo
pushed a commit
that referenced
this pull request
Jun 15, 2017
Allow core-graphics 0.8 and bump version <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/cocoa-rs/162) <!-- Reviewable:end -->
|
@bors-servo r=emilio |
|
📌 Commit 4375963 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 15, 2017
Allow core-graphics 0.8 and bump version <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/cocoa-rs/162) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is