This repository was archived by the owner on Jul 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Fix linking on Rust versions that unprefix jemalloc #46
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,18 @@ | ||
language: rust | ||
rust: nightly | ||
rust: | ||
# Jemalloc prefixing change between these two versions | ||
- nightly-2016-02-14 | ||
- nightly-2016-02-17 | ||
|
||
- nightly | ||
- beta | ||
- stable | ||
|
||
notifications: | ||
webhooks: http://build.servo.org:54856/travis | ||
|
||
script: | ||
- cargo test | ||
- "[ $TRAVIS_RUST_VERSION = nightly ] || cargo test --features unstable" | ||
- "[ $TRAVIS_RUST_VERSION = nightly ] || cargo test --manifest-path plugin/Cargo.toml" | ||
- "[ $TRAVIS_RUST_VERSION != nightly ] || cargo test --features unstable" | ||
- "[ $TRAVIS_RUST_VERSION != nightly ] || cargo test --manifest-path plugin/Cargo.toml" | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
extern crate regex; | ||
|
||
use std::env::var; | ||
use std::process::Command; | ||
use std::str; | ||
|
||
fn main() { | ||
let version_line = Command::new(var("RUSTC").unwrap_or("rustc".into())) | ||
.arg("--version") | ||
.output() | ||
.unwrap() | ||
.stdout; | ||
let captures = regex::Regex::new(r"rustc (\d+)\.(\d+)\.(\d+).+(\d{4}-\d{2}-\d{2})\)") | ||
.unwrap() | ||
.captures(str::from_utf8(&version_line).unwrap()) | ||
.unwrap(); | ||
let version = ( | ||
captures[1].parse::<u32>().unwrap(), | ||
captures[2].parse::<u32>().unwrap(), | ||
captures[3].parse::<u32>().unwrap(), | ||
&captures[4], | ||
); | ||
if version < (1, 8, 0, "2016-02-14") { | ||
println!("cargo:rustc-cfg=prefixed_jemalloc"); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't test unstable and plugin on
nightly-*
though, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but the point of having these two dated version is to test the build script’s version parsing and the linking to
je_malloc_usable_size
. These versions are not special as far as theunstable
feature and the plugin are concerned.