Cargo & general updates. #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert_eq!(Atom::from_str("").to_string(), "".to_string()); | ||
| assert_eq!(Atom::from_str("body").to_string(), "body".to_string()); | ||
| assert_eq!(Atom::from_str("asdfghjk").to_string(), "asdfghjk".to_string()); | ||
| assert_eq!(Atom::from_str("").to_string(), "atom!()".to_string()); |
There was a problem hiding this comment.
.to_string now uses the Show impl for a type, and thus this changed; it may not be the correct way you wish to handle this.
|
Merged via cherry-pick. Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows html5ever to be built via cargo and via the makefiles. Currently
cargo buildandcargo docwork fine, butcargo testdoesn't:#[test]s at the moment (Support non-#[test] tests/non-#[bench] benchmarks rust-lang/cargo#431)There was a pile of file movement to get it into a format that works most naturally with cargo, although, I didn't touch
bench(even though it's not special directory in cargo, theoretically it would move undertests); and the more interesting benchmarking means there may be some form ofMakefiledesired still.I don't know what version or authors you'd like listed; and I'm sort-of expecting this to just be a "get the ball rolling" PR, since I feel you may wish to prod and tweak (especially around what happens with the Makefile and benchmarking). I can drop the second commit if that's going too far into the future.
Fixes #27.