Don't use utf8 logic to parse unquoted urls. #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes the benchmark I added go from: 580,075 ns/iter (+/- 15,881) to 261,823 ns/iter (+/- 11,536) |
|
r? @SimonSapin |
|
Looks good! Could you do the same for quoted strings? Thanks |
emilio
force-pushed
the
data-uri
branch
2 times, most recently
from
d7bcfa1 to
ce22a3e
Compare
|
Done. Note that we could also add this fast path when escapes are present, but that includes using |
|
Yeah, I don't have data on this but I suspect that CSS escapes are not very common. |
emilio
force-pushed
the
data-uri
branch
2 times, most recently
from
c8d1c19 to
ef0858f
Compare
|
Reviewed 2 of 3 files at r3, 1 of 1 files at r4, 1 of 1 files at r5. src/tests.rs, line 586 at r5 (raw file):
Please move this to a separate src/tokenizer.rs, line 857 at r5 (raw file):
Nit: src/tokenizer.rs, line 1016 at r5 (raw file):
Nit: the Comments from Reviewable |
Current values: test tests::unquoted_url ... bench: 580,075 ns/iter (+/- 15,881)
261,823 ns/iter (+/- 11,536)
emilio
force-pushed
the
data-uri
branch
2 times, most recently
from
5230756 to
ed27364
Compare
|
Addressed all review comments except the And i can't use |
If this is still too slow, the other thing to do would be to use table lookup to scan the properties of the given byte in all these hot loops.
|
@bors-servo r+ Reviewed 3 of 4 files at r6, 1 of 1 files at r7. Comments from Reviewable |
|
📌 Commit 673623f has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 1, 2016
Don't use utf8 logic to parse unquoted urls. Since it's not needed, and it's noticeable when parsing large data-uris, like servo/servo#13778. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/110) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's not needed, and it's noticeable when parsing large data-uris, like servo/servo#13778.
This change is