Skip to content

Test failure for data://test:test/,X in the data-url crate #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
djc opened this issue Aug 18, 2020 · 3 comments
Closed

Test failure for data://test:test/,X in the data-url crate #626

djc opened this issue Aug 18, 2020 · 3 comments

Comments

@djc
Copy link
Contributor

djc commented Aug 18, 2020

There's a panic here:

thread 'data: URL "data://test:test/,X"' panicked at 'Mime { type_: "text", subtype: "plain", parameters: [("charset", "US-ASCII")] }', .tests/wpt.rs:20:9

which appears to have been around at least since the data-url crate was moved into this repository around Feb 2018 (cc670f6).
@djc
Copy link
Contributor Author

djc commented Aug 18, 2020

For some reason this does not show up as a test failure, which seems strange. Should investigate.

@djc
Copy link
Contributor Author

djc commented Aug 19, 2020

Apparently this might be expected: #473.

@djc
Copy link
Contributor Author

djc commented Aug 25, 2020

This was fixed by the changes in #473.

@djc djc closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djc