Reduce build noise #473
Closed
Reduce build noise #473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hook panic with nop, unexpected panics still work as expected.
SimonSapin
reviewed
Nov 28, 2018
data-url/tests/wpt.rs
Outdated
| @@ -135,6 +135,7 @@ fn collect_mime<F>(add_test: &mut F) | |||
| } | |||
|
|
|||
| fn main() { | |||
| std::panic::set_hook(Box::new(|_| {})); | |||
There was a problem hiding this comment.
I don’ think this is appropriate. Panic output/backtraces can be essential, especially when tests are failing.
There was a problem hiding this comment.
Addressed by d593f4c
On panic, evaluate the test case for the expected panic flag, silence if so flagged.
|
☔ The latest upstream changes (presumably #517) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is