Added RESERVED_ENCODE_SET & STRICT_ENCODE_SET & more detailed docs. #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… delimeter characters, and STRICT_ENCODE_SET that encodes everything expect unreserved characters. Added more detailed descriptions to existings sets.
|
Resolves #353 |
golddranks
changed the title
|
☔ The latest upstream changes (presumably #335) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I’m opposed to adding new encode sets just because they exist in some RFC. This is why the Closing in favor of #355 for the rest of the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RESERVED_ENCODE_SET that corresponds to the set of reserved URL delimeter characters, and STRICT_ENCODE_SET that encodes everything expect unreserved characters. (As defined in the RFC 3986) Added more detailed descriptions to the existings sets.
This change is