-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[Windows] add installing lld-link.exe to the readme? #21243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
@jasonwilliams I think we'd definitely take a change to the readme that points at this - anything that makes the dev experience better is 👍 from me! |
4 tasks
bors-servo
pushed a commit
that referenced
this issue
Oct 8, 2018
Add optional section to README for using lld-link on Windows <!-- Please describe your changes on the following line: --> Switching to lld-link as described in #21243 decreased Windows dev build times for 1-line changes from 20 minutes to 10 minutes for me. The last comment on that issue mentioned that a readme change might be welcome, hopefully this is useful 😄 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21243 <!-- Either: --> - [x] These changes do not require tests because they only affect the README <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21889) <!-- Reviewable:end -->
bors-servo
pushed a commit
that referenced
this issue
Oct 9, 2018
Add optional section to README for using lld-link on Windows <!-- Please describe your changes on the following line: --> Switching to lld-link as described in #21243 decreased Windows dev build times for 1-line changes from 20 minutes to 10 minutes for me. The last comment on that issue mentioned that a readme change might be welcome, hopefully this is useful 😄 --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #21243 <!-- Either: --> - [x] These changes do not require tests because they only affect the README <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21889) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Developing Servo on Windows 10 can be painfully slow using the built-in linker.
Every build (even from the smallest change) can take around 30mins, i believe this is due to this bug:
rust-lang/rust#37543
Thanks to help from @retep998 ive had significant speed ups using lld-link instead, so should other Servo devs be setting this up?
Setup instructions
Until the issue above is fixed should we recommend users install lld-link.exe instead?
Setup
Ryzen 7 1700 (8 Cores/16 Threads)
@larsbergstrom @vvuk @jdm @SimonSapin
The text was updated successfully, but these errors were encountered: