Various enhancements #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -272,6 +253,29 @@ impl fmt::Show for Atom { | |||
| } | |||
| } | |||
|
|
|||
| impl Str for Atom { | |||
There was a problem hiding this comment.
Would it make sense to leave the Str implementation until the rust team make the change in stdlib so that Str does not imply Equiv?
There was a problem hiding this comment.
I'm not familiar with this issue -- can you elaborate?
There was a problem hiding this comment.
It's in relation to this - rust-lang/rust#16738
|
Have you tested cross compiling to android? If not, I can test that once it's merged into servo and fix any issues if you want to do it that way. Otherwise, looks good to me! |
|
I haven't tested cross compiling, and I don't have an easy way to do so, so I think it would be better to test once it's merged in Servo. |
This helps us make a C-friendly library, which is important for html5ever.
We can't make these simple Atom constants, because the Atom type has a destructor.
|
I'll get rid of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Servo's Rust is too old to build this code, but I want these changes for html5ever.
We can update Servo's submodule after the next Rust upgrade (which is already needed to land html5ever).