Skip to content

IdNamespace is unique only within webrender instance #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sotaroikeda opened this issue Oct 3, 2017 · 2 comments
Closed

IdNamespace is unique only within webrender instance #1794

sotaroikeda opened this issue Oct 3, 2017 · 2 comments
Labels
type: enhancement

Comments

@sotaroikeda
Copy link
Contributor

IdNamespace allocation is managed within webrender instance . Therefore there could be a case that different RenderApi could have same namespace_id between different webrender instances.

It causes the problem like Bug 1405241 on gecko since gecko assumes unique IdNamespace even between different webrender instances.

I am not sure if the problem should be addressed gecko side or webrender side.
@kvark
Copy link
Member

kvark commented Oct 3, 2017

I believe the end goal is to have a single WR instance anyway, that is managing multiple independent documents/scenes. In that case, WR will not need to have any built-in protection from multiple instances collision. However, in order to allow this to be patched on the Gecko side, WR does need to provide some way to make those IdNamespace different.

@JerryShih JerryShih mentioned this issue Oct 16, 2017
Merged
bors-servo pushed a commit that referenced this issue Oct 20, 2017
Auto merge of #1882 - JerryShih:unique-IdNamespace, r=glennw
56a452d 
Use a global static variable for IdNamespace counting.

#1794
Try to use a simple global static variable for that id counting. That's not thread safe. All render-backend should be created in the same thread. If we try to handle the thread problem, I will turn to use thread_local.

cc @sotaroikeda
r? @kvark @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/1882)
<!-- Reviewable:end -->
@glennw
Copy link
Member

glennw commented Oct 23, 2017

#1882 has landed.

@glennw glennw closed this as completed Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @sotaroikeda @glennw