Skip to content

Conversation

@tamird
Copy link
Contributor

@tamird tamird commented May 3, 2023

This should provide the same coverage as the CircleCI config.

This should provide the same coverage as the CircleCI config.
@tamird
Copy link
Contributor Author

tamird commented May 4, 2023

@dpc does this look valuable to you?

@dpc dpc merged commit f378d94 into sfackler:master May 4, 2023
@tamird tamird deleted the add-github-action branch May 4, 2023 16:41
@tamird
Copy link
Contributor Author

tamird commented May 4, 2023

@dpc looks like the new action is passing: https://github.com/sfackler/rust-fallible-iterator/actions. Shall I send another PR to remove the CircleCI config?

@dpc
Copy link
Collaborator

dpc commented May 4, 2023

Let's wait to see if anyone has anything against it, but fine with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants