add EcPointRef::to_hex_str and EcPoint::from_hex_str #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zh-jq
force-pushed
the
ec_point_to_hex_str
branch
2 times, most recently
from
91878f0 to
8029016
Compare
sfackler
reviewed
Jul 20, 2023
sfackler
reviewed
Jul 20, 2023
| /// Creates point from a hexadecimal string representation | ||
| #[corresponds(EC_POINT_hex2point)] | ||
| #[cfg(not(boringssl))] | ||
| pub fn from_hex_str( |
There was a problem hiding this comment.
I think we'd want this to take &mut self rather than being a static method taking the group.
There was a problem hiding this comment.
The definition is the same as EcPoint::from_bytes. For a &mut self method, it seems the name set_from_hex_str is more suited.
zh-jq
force-pushed
the
ec_point_to_hex_str
branch
from
8029016 to
ebf8027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.openssl.org/docs/manmaster/man3/EC_POINT_point2hex.html