Improve support for OPENSSL_NO_COMP and OPENSSL_NO_SRTP #2423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the libressl test failures look relevant here, if you can take a look |
|
LibreSSL never had the #error that is being worked around here. We've defined I also don't know why LibreSSL 2.5.x from 2017 is still being dragged along. |
justsmth
force-pushed
the
bindgen-feature-macros
branch
from
88d4220 to
67cc7ec
Compare
justsmth
force-pushed
the
bindgen-feature-macros
branch
from
67cc7ec to
0e91ccc
Compare
|
Is anything else needed for this PR? |
alex
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve support for OPENSSL_NO_COMP and OPENSSL_NO_SRTP.
This PR addresses two potential failures:
During bindgen -- the INCLUDES tries to
#include <openssl/comp.h>even when comp.h isn't available.During linking -- when built with
OPENSSL_NO_SRTP, the SRTP functions are not available.