"Weltfrauentag" regions wrong

[s-schmoll]

Hey there,

thanks again for adding the regions array. It seems like there has been added a little bug for "WELTFRAUENTAG". This holiday is only for Berlin and Mecklemburg-Vorpommern, but regions are returning "ALL"

{ "name": "WELTFRAUENTAG", "date": "2024-03-07T23:00:00.000Z", "dateString": "2024-03-08", "regions": [ "BW", "BY", "BE", "BB", "HB", "HE", "HH", "MV", "NI", "NW", "RP", "SL", "SN", "ST", "SH", "TH", "BUND", "ALL" ] }

I guess there happened to be a mistake in line 403 and 407 within your feiertage.ts file: feiertageObjects.push(newHoliday('WELTFRAUENTAG', makeDate(year, 3, 8), ['ALL']));

There could be also more holidays affected. F.e. "WELTKINDERTAG".

For "REFORMATIONSTAG" the validRegions List includes NI twice:

const validRegions: Region[] = [ 'NI', 'BB', 'MV', 'SN', 'ST', 'TH', 'HB', 'HH', 'NI', 'SH', ];

[sfakir]

Hi @s-schmoll,
thank you for the detailed review!
Definitley a mistake, I fixed it for the various holdiays and published a new version (1.4.1).

Best,

Simon