Update const.py to reflect 1052 register unit change in documentation #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"pvinverter_power_total": RegisterInfo(1052, INT32, UnitOfPower.WATT), Change to WATT
bifbaf
approved these changes
Oct 24, 2023
jumoog
approved these changes
Nov 10, 2023
sfstar
approved these changes
Feb 27, 2024
Owner
sfstar
left a comment
sfstar
left a comment
There was a problem hiding this comment.
LGTM,
Victron responded in:
victronenergy/dbus_modbustcp#30
New XLSX has been made available for v3.20 of the gx software.
Next to new register this integration can start to include this register was also changed to WATT instead of KILO_WATT
sfstar
changed the title
|
@sfstar You can always look at the latest xlsx document in our repo. When a new venus release is made, we upload the corresponding version to the Victron website for customers, but as a developer you are welcome to use the "alpha" version in the git repo. Right now you will see there are a few registers in the latest one that did not make it in to 3.20, mostly related to the new Orion XS DC/DC converter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"pvinverter_power_total": RegisterInfo(1052, INT32, UnitOfPower.WATT),
Change to WATT